Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow state access role to be updated #159

Merged
merged 28 commits into from
Aug 26, 2021
Merged

Allow state access role to be updated #159

merged 28 commits into from
Aug 26, 2021

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Jul 16, 2021

Depends on #157
Closes #147
Closes #169
Closes #170
Closes #171
Closes #173

Allows a state object to be updated with a new role

TODO:

  • Write documentation for /api/state_unids
  • Make a better sharing UI
  • Test that role can be updated and it affects ability to write

@haihan-lin
Copy link
Collaborator

This needs to be updated to the new refactored master, so that I can work on the front-end with new libraries.

@haihan-lin
Copy link
Collaborator

Still WIP. @JackWilb is there a way to pull from server a list of uID that the state are shared with and their access? this way the front end can display the list of uID and access, allowing the user to change.

@haihan-lin haihan-lin linked an issue Aug 23, 2021 that may be closed by this pull request
@JackWilb
Copy link
Member Author

Rebased after #172

Copy link
Member Author

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we could remove this

frontend/src/Interfaces/Store.ts Outdated Show resolved Hide resolved
@haihan-lin
Copy link
Collaborator

Added a new dialog to allow change row access.

Expected behavior: clicking edit in "state management" will lead the user to the access change dialog.

switching the radio button to change access.

Will need some testing together with @JackWilb since I can't test it properly.

@JackWilb JackWilb marked this pull request as ready for review August 26, 2021 16:28
@JackWilb JackWilb merged commit 639492c into master Aug 26, 2021
@JackWilb JackWilb deleted the update-access-level branch August 26, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants