Skip to content

Commit

Permalink
chore: fix lint warnings (#8764)
Browse files Browse the repository at this point in the history
  • Loading branch information
Pessimistress committed Apr 6, 2024
1 parent 68a354a commit 404ae57
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ export default class HeatmapLayer<
}

_updateMaxWeightValue() {
const {maxWeightTransform, textureSize} = this.state;
const {maxWeightTransform} = this.state;

maxWeightTransform!.run({
parameters: {viewport: [0, 0, 1, 1]},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

import {Device, Texture} from '@luma.gl/core';
import {Texture} from '@luma.gl/core';
import {Model, Geometry} from '@luma.gl/engine';
import {Layer, LayerProps, log, picking, UpdateParameters, DefaultProps} from '@deck.gl/core';
import {defaultColorRange, colorRangeToFlatArray} from '../utils/color-utils';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import type {Device, DeviceFeature} from '@luma.gl/core';
import {Model, TextureTransform} from '@luma.gl/engine';
import {fp64arithmetic} from '@luma.gl/shadertools';
import {GL} from '@luma.gl/constants';
import {log, project32, _mergeShaders as mergeShaders, getShaderAssembler} from '@deck.gl/core';
import {project32, _mergeShaders as mergeShaders, getShaderAssembler} from '@deck.gl/core';

import {
DEFAULT_RUN_PARAMS,
Expand Down Expand Up @@ -397,7 +397,7 @@ export default class GPUGridAggregator {

// render all aggregated grid-cells to generate Min, Max or MaxMin data texture
_renderToMaxMinTexture(opts) {
const {id, parameters, gridSize, minOrMaxFb, combineMaxMin, clearParams = {}} = opts;
const {id, gridSize, minOrMaxFb, combineMaxMin, clearParams = {}} = opts;
const {framebuffers} = this.state;
const {allAggregationModel} = this;

Expand Down
2 changes: 2 additions & 0 deletions modules/carto/src/layers/vector-tile-layer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export default class VectorTileLayer<
return loadOptions;
}

/* eslint-disable camelcase */
async getTileData(tile: TileLoadProps) {
const tileJSON = this.props.data as TilejsonResult;
const {tiles, properties_tiles} = tileJSON;
Expand Down Expand Up @@ -115,6 +116,7 @@ export default class VectorTileLayer<

return attributes ? mergeBoundaryData(geometry, attributes) : geometry;
}
/* eslint-enable camelcase */

renderSubLayers(
props: TileLayer['props'] & {
Expand Down
3 changes: 0 additions & 3 deletions modules/core/src/lib/deck.ts
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,6 @@ export default class Deck<ViewsT extends ViewOrViews = null> {
...props.deviceProps,
canvas: this._createCanvas(props)
});
deviceOrPromise.then(device => {
this.device = device;
});
}

this.animationLoop = this._createAnimationLoop(deviceOrPromise, props);
Expand Down
2 changes: 0 additions & 2 deletions modules/core/src/shaderlib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

import {Device} from '@luma.gl/core';
import {ShaderAssembler} from '@luma.gl/shadertools';

import {gouraudLighting, phongLighting} from '@luma.gl/shadertools';
import project from './project/project';
import project32 from './project32/project32';
import shadow from './shadow/shadow';
import picking from './picking/picking';
import {PipelineFactory} from '@luma.gl/engine';

const DEFAULT_MODULES = [project];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {equals} from '@math.gl/core';
import {_deepEqual as deepEqual} from '@deck.gl/core';
import type {Effect, EffectContext, Layer, PreRenderOptions, Viewport} from '@deck.gl/core';
import CollisionFilterPass from './collision-filter-pass';
import MaskEffect, {MaskPreRenderStats} from '../mask/mask-effect';
import {MaskPreRenderStats} from '../mask/mask-effect';
// import {debugFBO} from '../utils/debug';

type CollisionFilterExtensionProps = {
Expand Down
10 changes: 7 additions & 3 deletions modules/mesh-layers/src/scenegraph-layer/scenegraph-layer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,13 @@ export default class ScenegraphLayer<DataT = any, ExtraPropsT extends {} = {}> e
const gltfObjects = createScenegraphsFromGLTF(device, processedGLTF, this._getModelOptions());
scenegraphData = {gltf: processedGLTF, ...gltfObjects};

waitForGLTFAssets(gltfObjects).then(() => {
this.setNeedsRedraw();
}); // eslint-disable-line @typescript-eslint/no-floating-promises
waitForGLTFAssets(gltfObjects)
.then(() => {
this.setNeedsRedraw();
})
.catch(ex => {
this.raiseError(ex, 'loading glTF');
});
}

const options = {layer: this, device: this.context.device};
Expand Down

0 comments on commit 404ae57

Please sign in to comment.