carto(v8.9): fix CartoLayer tests (#8436)

visgl · Jan 19, 2024 · 52a232b · 52a232b
1 parent 69f2c86
commit 52a232b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/test/modules/carto/api/maps-api-client.spec.js b/test/modules/carto/api/maps-api-client.spec.js
@@ -147,11 +147,6 @@ const TABLE_PARAMS = {
     params: {...TABLE_PARAMS, type: MAP_TYPES.TILESET, geoColumn: 'geo'},
     regex: /geoColumn parameter is not supported by type tileset/
   },
-  {
-    title: 'query + columns',
-    params: {...TABLE_PARAMS, type: MAP_TYPES.QUERY, columns: ['geo']},
-    regex: /columns parameter is not supported by type query/
-  },
   {
     title: 'no geoColumn + aggregationExp',
     params: {...TABLE_PARAMS, aggregationExp: 'sum(x) as y'},

diff --git a/test/modules/carto/carto-layer.spec.js b/test/modules/carto/carto-layer.spec.js
@@ -101,7 +101,8 @@ mockedV3Test('CartoLayer#v3', async t => {
         props: {
           ...props,
           data: 'select * from table',
-          type: MAP_TYPES.QUERY
+          type: MAP_TYPES.QUERY,
+          columns: ['a', 'b']
         },
         onAfterUpdate
       },
@@ -117,7 +118,8 @@ mockedV3Test('CartoLayer#v3', async t => {
         props: {
           ...props,
           data: 'table',
-          type: MAP_TYPES.TABLE
+          type: MAP_TYPES.TABLE,
+          columns: ['a', 'b']
         },
         onAfterUpdate
       },
@@ -252,7 +254,7 @@ mockedV1Test('CartoLayer#should throw with invalid params for v1 and v2', t => {
       },
       regex: /geoColumn prop is only supported for type/i
     })),
-    ...[MAP_TYPES.TILESET, MAP_TYPES.QUERY].map(type => ({
+    ...[MAP_TYPES.TILESET].map(type => ({
       title: `should throw when columns prop is used with type ${type}`,
       props: {
         ...layer.props,