Deep comparison of parameters prop in Layer (#6754)

visgl · Mar 31, 2022 · 6256b9e · 6256b9e
1 parent f84198c
commit 6256b9e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/modules/core/src/lib/layer.js b/modules/core/src/lib/layer.js
@@ -122,7 +122,7 @@ const defaultProps = {
   positionFormat: 'XYZ',
   colorFormat: 'RGBA',
 
-  parameters: {},
+  parameters: {type: 'object', value: {}, optional: true, compare: true},
   transitions: null,
   extensions: [],
   loaders: {type: 'array', value: [], optional: true, compare: true},

diff --git a/modules/core/src/lifecycle/prop-types.ts b/modules/core/src/lifecycle/prop-types.ts
@@ -1,4 +1,5 @@
 import {createTexture, destroyTexture} from '../utils/texture';
+import {deepEqual} from '../utils/deep-equal';
 
 import type Component from './component';
 
@@ -57,6 +58,8 @@ type ImagePropType = BasePropType & {
 };
 type ObjectPropType = BasePropType & {
   type: 'object';
+  optional?: boolean;
+  compare?: boolean;
 };
 type DeprecatedProp = {
   deprecatedFor?: string | string[];
@@ -127,6 +130,11 @@ const TYPE_DEFINITIONS = {
       return propType.compare ? arrayEqual(value1, value2) : value1 === value2;
     }
   },
+  object: {
+    equal(value1, value2, propType: ObjectPropType) {
+      return propType.compare ? deepEqual(value1, value2) : value1 === value2;
+    }
+  },
   function: {
     validate(value, propType: FunctionPropType) {
       return (propType.optional && !value) || typeof value === 'function';