Fix H3ClusterLayer accessors (#7812)

visgl · Apr 5, 2023 · 7c6140c · 7c6140c
1 parent 9ba6900
commit 7c6140c
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/modules/geo-layers/src/h3-layers/h3-cluster-layer.ts b/modules/geo-layers/src/h3-layers/h3-cluster-layer.ts
@@ -57,9 +57,16 @@ export default class H3ClusterLayer<DataT = any, ExtraProps extends {} = {}> ext
   }
 
   indexToBounds(): Partial<GeoCellLayer['props']> {
+    const {getElevation, getFillColor, getLineColor, getLineWidth} = this.props;
+
     return {
       data: this.state.polygons,
-      getPolygon: d => d.polygon
+      getPolygon: d => d.polygon,
+
+      getElevation: this.getSubLayerAccessor(getElevation),
+      getFillColor: this.getSubLayerAccessor(getFillColor),
+      getLineColor: this.getSubLayerAccessor(getLineColor),
+      getLineWidth: this.getSubLayerAccessor(getLineWidth)
     };
   }
 }
diff --git a/test/modules/geo-layers/h3-layers.spec.js b/test/modules/geo-layers/h3-layers.spec.js
@@ -366,3 +366,31 @@ test('H3ClusterLayer', t => {
 
   t.end();
 });
+
+/** Verify that accessors are properly wrapped to access the source object */
+test('H3ClusterLayer#accessor', t => {
+  const elevations = [];
+
+  testLayer({
+    Layer: H3ClusterLayer,
+    onError: t.notOk,
+    testCases: [
+      {
+        props: {
+          data,
+          getHexagons: d => d.hexagons,
+          getElevation: d => {
+            const elevation = d.size;
+            elevations.push(elevation);
+            return elevation;
+          }
+        },
+        onAfterUpdate: () => {
+          t.ok(elevations.every(Number.isFinite), 'Elevations populated');
+        }
+      }
+    ]
+  });
+
+  t.end();
+});