CARTO: Handle DEFAULT-INITIAL-VIEWPORT in H3Tileset2D (#7924)

visgl · May 31, 2023 · a55b9d1 · a55b9d1
1 parent cfa79d8
commit a55b9d1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/modules/carto/src/layers/h3-tileset-2d.ts b/modules/carto/src/layers/h3-tileset-2d.ts
@@ -75,6 +75,7 @@ export default class H3Tileset2D extends Tileset2D {
    */
   // @ts-expect-error Tileset2D should be generic over TileIndex
   getTileIndices({viewport, minZoom, maxZoom}): H3TileIndex[] {
+    if (viewport.latitude === undefined) return [];
     const [east, south, west, north] = viewport.getBounds();
 
     let z = getHexagonResolution(viewport);

diff --git a/test/modules/carto/layers/h3-tileset-2d.spec.js b/test/modules/carto/layers/h3-tileset-2d.spec.js
@@ -1,6 +1,6 @@
 import test from 'tape-promise/tape';
 import H3Tileset2D from '@deck.gl/carto/layers/h3-tileset-2d';
-import {WebMercatorViewport} from '@deck.gl/core';
+import {Viewport, WebMercatorViewport} from '@deck.gl/core';
 import {equals} from '@math.gl/core';
 
 test('H3Tileset2D', async t => {
@@ -112,3 +112,12 @@ test('H3Tileset2D max zoom', async t => {
   t.equal(indices.length, 7, 'max zoom added');
   t.end();
 });
+
+test('H3Tileset2D default viewport', async t => {
+  const tileset = new H3Tileset2D({});
+  // See layer-manager.ts
+  const viewport = new Viewport({id: 'DEFAULT-INITIAL-VIEWPORT'});
+  let indices = tileset.getTileIndices({viewport});
+  t.equal(indices.length, 0, 'Empty initial viewport');
+  t.end();
+});