explicitly create AttributeManager

visgl · May 12, 2024 · c354c6e · c354c6e
1 parent 134a139
commit c354c6e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/modules/aggregation-layers/src/aggregation-layer-v9/aggregation-layer.ts b/modules/aggregation-layers/src/aggregation-layer-v9/aggregation-layer.ts
@@ -4,7 +4,8 @@ import {
   LayerContext,
   UpdateParameters,
   CompositeLayerProps,
-  Attribute
+  Attribute,
+  AttributeManager
 } from '@deck.gl/core';
 import {Aggregator} from './aggregator';
 
@@ -28,7 +29,7 @@ export default abstract class AggregationLayer<
     cpuAggregator: CPUAggregator | null;
   };
 
-  /** Allow this layer to have an AttributeManager and participates in the draw cycle */
+  /** Allow this layer to participates in the draw cycle */
   get isDrawable() {
     return true;
   }
@@ -89,6 +90,14 @@ export default abstract class AggregationLayer<
     return this.state.gpuAggregator || this.state.cpuAggregator;
   }
 
+  // override CompositeLayer._getAttributeManager to create AttributeManager instance
+  _getAttributeManager() {
+    return new AttributeManager(this.context.device, {
+      id: this.props.id,
+      stats: this.context.stats
+    });
+  }
+
   // Override CompositeLayer._postUpdate to update attributes and the CPUAggregator
   protected _postUpdate(updateParams: UpdateParameters<this>, forceUpdate: boolean) {
     this._updateAttributes();

diff --git a/modules/core/src/lib/layer.ts b/modules/core/src/lib/layer.ts
@@ -884,7 +884,7 @@ export default abstract class Layer<PropsT extends {} = {}> extends Component<
 
     debug(TRACE_INITIALIZE, this);
 
-    const attributeManager = this.isDrawable ? this._getAttributeManager() : null;
+    const attributeManager = this._getAttributeManager();
 
     if (attributeManager) {
       // All instanced layers get instancePickingColors attribute by default