Skip to content

Commit

Permalink
Remove project module hacks in transitions
Browse files Browse the repository at this point in the history
  • Loading branch information
felixpalmer committed May 7, 2024
1 parent f3f62b9 commit dac757d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 0 additions & 2 deletions modules/core/src/transitions/gpu-interpolation-transition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
getFloat32VertexFormat
} from './gpu-transition-utils';
import {GPUTransitionBase} from './gpu-transition';
import project from '../shaderlib/project/project';

import type {InterpolationTransitionSettings} from '../lib/attribute/transition-settings';
import type {TypedArray} from '../types/types';
Expand Down Expand Up @@ -207,7 +206,6 @@ function getTransform(device: Device, attribute: Attribute): BufferTransform {
varyings: ['vCurrent'],

// TODO investigate why this is needed
modules: [project],
disableWarnings: true
});
}
6 changes: 1 addition & 5 deletions modules/core/src/transitions/gpu-spring-transition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
} from './gpu-transition-utils';
import Attribute from '../lib/attribute/attribute';
import {GPUTransitionBase} from './gpu-transition';
import project from '../shaderlib/project/project';

import type {SpringTransitionSettings} from '../lib/attribute/transition-settings';
import type {TypedArray} from '../types/types';
Expand Down Expand Up @@ -178,10 +177,7 @@ function getTransform(device: Device, attribute: Attribute): BufferTransform {
blendAlphaOperation: 'max',
blendAlphaSrcFactor: 'one',
blendAlphaDstFactor: 'one'
},

// TODO investigate why this is needed
modules: [project]
}
});
}

Expand Down

0 comments on commit dac757d

Please sign in to comment.