Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onHover/onClick index property missing from choropleths on 3.0.0-beta21 #116

Closed
yocontra opened this issue Oct 19, 2016 · 2 comments
Closed

onHover/onClick index property missing from choropleths on 3.0.0-beta21 #116

yocontra opened this issue Oct 19, 2016 · 2 comments

Comments

@yocontra
Copy link
Contributor

screen shot 2016-10-19 at 11 14 41 am

Works fine on beta17, beta21 is missing the index + feature attributes.

Other layers have the index attr but no object, this one is missing both so I figured I would open a different ticket since it probably stems from something else.

You can reproduce this on the example demo using any of the choropleth layers.
@ibgreen
Copy link
Collaborator

ibgreen commented Oct 20, 2016

Fixed in beta22

@ibgreen ibgreen closed this as completed Oct 20, 2016
@ibgreen ibgreen reopened this Oct 20, 2016
@yocontra
Copy link
Contributor Author

Just tested on beta22 - doesn't seem to be fixed. Same with #115

ibgreen pushed a commit that referenced this issue Oct 29, 2016
Picking cleanup. Fixes #115. Fixes #116.
6d7931d
ibgreen added a commit that referenced this issue Oct 29, 2016
@ibgreen
Fixes to minor issues (#135)
23973d1 
- BREAKING CHANGE: Picking API final version. Fixes #115. Fixes #116.
- FIX: Ignore null layers
- FIX: Warns once instead of throws on deprecated props.
- FIX: Pinned babel-plugin-glslify version to avoid broken release
@ibgreen ibgreen closed this as completed Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yocontra @ibgreen