Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScenegraphLayer: Support glTF KHR_materials_unlit extension #3705

Closed
5 tasks
ibgreen opened this issue Sep 26, 2019 · 2 comments
Closed
5 tasks

ScenegraphLayer: Support glTF KHR_materials_unlit extension #3705

ibgreen opened this issue Sep 26, 2019 · 2 comments
Labels
Milestone

Comments

@ibgreen
Copy link
Collaborator

ibgreen commented Sep 26, 2019

Target Use case

Photogrammetry is already lit, no additional lighting should be applied.

Proposed feature

  • GLTFLoader in loaders.gl now supports this extension.
  • Check material.unlit, in this case just render the base color texture.

To Do List

  • Add label and assign to milestone
  • Coding
  • Doc update
  • What’s new update
  • Test
@ibgreen
Copy link
Collaborator Author

ibgreen commented Dec 10, 2019

AFAIK, this is only handled in loaders.gl. It also needs to be handled in luma.gl lighting modules and verified/plumbed through in deck.gl.

Use case: This extension is needed for supporting 3d tiles with photogrammetry.

Maybe move this to v8.x instead of closing?

@ibgreen ibgreen reopened this Dec 10, 2019
@tgorkin
Copy link
Contributor

tgorkin commented Dec 10, 2019

Sorry, incorrectly assumed this was complete as part of the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants