Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadertools: Support glTF unlit flag in PBR materials #1394

Closed
wants to merge 2 commits into from
Closed

shadertools: Support glTF unlit flag in PBR materials #1394

wants to merge 2 commits into from

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 17, 2020 •
edited

Fixes 3D tiles lighting:

image

For #947

Background

Change List

  • Add new uniform to PBR module

@ibgreen
Copy link
Collaborator Author

ibgreen commented Sep 22, 2020 •
edited

@igorDykhta you suggested we need to make additional changes to be compliant with https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_materials_unlit

@ibgreen
Copy link
Collaborator Author

ibgreen commented Oct 1, 2020

Closed in favor of #1405

@ibgreen ibgreen closed this Oct 1, 2020
@Pessimistress Pessimistress deleted the ib/pbr-material-unlit branch November 16, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @Pessimistress