New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picking issue for non-fullscreen widget #444

Closed

gnavvy opened this issue Mar 21, 2017 · 1 comment

Labels

P0

Contributor

gnavvy commented Mar 21, 2017

uber/react-vis#304
picking for scatterplot layer does not work in the above PR.

https://github.com/uber/deck.gl/blob/master/src/react/deckgl.js#L133
here x and y should be relative positions to the canvas, not screen coordinates.

will fix for v4.0.

gnavvy added P0 v4.0 labels

gnavvy changed the title ~~picking issue for non-fully screen widget~~ picking issue for non-fullscreen widget

Collaborator

ibgreen commented Mar 22, 2017

Related to #248?

gnavvy mentioned this issue

use offsetX & offsetY instead of x & y to get relative positions #445

Merged

howtimeflies0 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment