use offsetX & offsetY instead of x & y to get relative positions #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Mar 22, 2017
src/react/deckgl.js
Outdated
| @@ -119,7 +119,7 @@ export default class DeckGL extends React.Component { | |||
|
|
|||
| // Route events to layers | |||
| _onClick(event) { | |||
| const {x, y} = event; | |||
| const {event: {offsetX: x = 0, offsetY: y = 0} = {}} = event; | |||
There was a problem hiding this comment.
- Since we are changing this to fix an issue should we add a line of comment why we are using
offsetXandoffsetY? - About the default values: Is this just a sanity check or is there are reason for the defaults? I.e. when is
offsetXandoffsetYundefined? Do we want to send a 0,0 event in those cases? Or drop the event? Or pass along the undefined so that app can check? Maybe add another comment line about this?
There was a problem hiding this comment.
Just a sanity check.
I agree it makes more sense to drop the event if either event.event is falsy (luma.gl addEvent fails, shouldn't be) or offsetX offsetY are falsy (browser fails, again shouldn't be according to the spec); it's also heavy and requires changes on existing apps if we surface the error message via the picked object.
will just drop the event if sanity check fails.
howtimeflies0
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #248 and #444
tested (ad-hoc) in the svg-interoperability example with a scolled offset.
will add a dedicated example consist of multiple non-full screen widgets later.