Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] [pydeck] Update frontend_semver.py when jupyter-widget version changes #7025

Open
dakoop opened this issue Jun 10, 2022 · 0 comments
Open
Milestone

Comments

@dakoop
Copy link
Contributor

dakoop commented Jun 10, 2022

Target Use Case

There are methods to bump versions across the various package.json files in deck.gl. However, pydeck's frontend_semver.py is not updated when these versions change. This may be because pydeck releases are not synchronized with deck.gl releases, but I could not find a documented way to run pydeck with the jupyter-widget module when building/running from source because the semver link between pydeck and jupyter-widget is broken, leading to errors:

Unhandled Promise Rejection: Error: Module @deck.gl/jupyter-widget, semver range ~8.5.* is not registered as a widget module

There is a bump_version.py script that pulls the version info from deck.gl and updates frontend_semver.py, but this is lumped in with setting the pydeck release (one has to choose major/minor, etc.)

Proposal

I see three potential solutions:

  1. Modify the bump_version.py script so it can be called to only run rewrite_frontend_version_file and put this step into the Makefile
  2. Create a separate script (e.g. link_frontend.py) that calls rewrite_frontend_version_file and document this in the installing from source docs
  3. Automatically update the frontend_semver.py file when deck.gl versions change

Note that these could be combined so that the link_frontend.py script is created, used in the Makefile, and also called as part of the global version update action.

@dakoop dakoop added the feature label Jun 10, 2022
dakoop added a commit to dakoop/deck.gl that referenced this issue Jun 10, 2022
Note that this ties it to 8.8.0-alpha.6; see visgl#7025 for comments
@donmccurdy donmccurdy added chore and removed feature labels Mar 29, 2024
@donmccurdy donmccurdy added this to the v9.0 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants