Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox Custom Layers + Example w. deck/mapbox layer interleaving #2264

Merged
merged 2 commits into from Sep 19, 2018
Merged

Mapbox Custom Layers + Example w. deck/mapbox layer interleaving #2264

merged 2 commits into from Sep 19, 2018

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 6, 2018

For #2132 Mapbox Custom Layer Integration

  • 2D layer integration, show deck.gl layer rendering under mapbox labels.

NEW: deck GeoJsonLayer under mapbox labels

screen shot 2018-09-06 at 4 19 19 pm

OLD: deck GeoJsonLayer on top of labels

screen shot 2018-09-06 at 4 19 02 pm

Change List

  • Move DeckLayer to new submodule
  • Add 2D example showing layer stack interleaving.
  • Start writing docs

@ibgreen ibgreen self-assigned this Sep 6, 2018
@ibgreen
Copy link
Collaborator Author

ibgreen commented Sep 6, 2018

@ansis

@ibgreen ibgreen added this to the 6.2.0 milestone Sep 6, 2018
@ibgreen ibgreen mentioned this pull request Sep 6, 2018
Closed
11 tasks
@ibgreen ibgreen changed the title PoC: 2D mapbox / deck layer interleaving Mapbox Custom Layers + Example w. deck/mapbox layer interleaving Sep 14, 2018
Pessimistress
Pessimistress approved these changes Sep 19, 2018
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this. I can fix 3d projection in a follow up PR.

@Pessimistress Pessimistress merged commit fbe4394 into master Sep 19, 2018
@Pessimistress Pessimistress deleted the ib/mapbox-layers branch September 19, 2018 15:53
@sakitam-fdd sakitam-fdd mentioned this pull request Sep 20, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

@nrabinowitz nrabinowitz Awaiting requested review from nrabinowitz

@alee8 alee8 Awaiting requested review from alee8

@heshan0131 heshan0131 Awaiting requested review from heshan0131

@1chandu 1chandu Awaiting requested review from 1chandu

@jianhuang01 jianhuang01 Awaiting requested review from jianhuang01

Assignees

@ibgreen ibgreen

Labels
code doc
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @Pessimistress