Update Mapbox integration documentation #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Sep 20, 2018
modules/mapbox-layers/README.md
Outdated
|
|
||
| * mapbox and deck.gl layers can be freely "interleaved", enabling a number of important uses cases as described below. | ||
| * mapbox and deck.gl layers can be freely "interleaved", enabling a number of layer mixing effects, such as drawing behind map labels; z-occlusion between deck.gl 3D objects and Mapbox buildings; etc. |
There was a problem hiding this comment.
replace semicolon with comma.
modules/mapbox-layers/README.md
Outdated
| * mapbox and deck.gl will share a single canvas and WebGL context, saving system resources. | ||
|
|
||
| Disadvantages: | ||
| ### Limitations |
There was a problem hiding this comment.
- Only works with mapbox-gl API
- No react-map-gl integration...
- deck.gl API cannot be used
There was a problem hiding this comment.
It can technically be used with react-map-gl, by accessing the map instance. We could also add addLayer and removeLayer methods onto the React component.
There was a problem hiding this comment.
Yes... I suppose we have three cases then:
- Use as a "mapbox" layer pack with raw mapbox API (supported)
- Use as a "mapbox" layer pack with
react-map-gl(can be supported with small extensions to react-map-gl, as you suggest). - Use with
DeckGLto let deck layers be rendered in between mapbox layers (not supported).
I think it would be great to add support for #2 especially as effort seems low, but obviously not having support for #3 is going to be a blocker for many users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2132