Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React example for Mapbox custom layer API #2311

Merged
merged 3 commits into from Sep 26, 2018
Merged

Add React example for Mapbox custom layer API #2311

merged 3 commits into from Sep 26, 2018

Conversation

Pessimistress
Copy link
Collaborator

For #2132
Depends on visgl/react-map-gl#603

ibgreen
ibgreen approved these changes Sep 26, 2018
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to land this, we can keep discussing and work incrementally from this point.

BTW - Don't we want two examples, i.e. keep the non-React mapbox API example around as well?

@Pessimistress Pessimistress changed the base branch from mapbox-api to master September 26, 2018 18:44
@Pessimistress Pessimistress changed the title [For Discussion] React example for Mapbox custom layer API Add React example for Mapbox custom layer API Sep 26, 2018
@Pessimistress Pessimistress merged commit b775505 into visgl:master Sep 26, 2018
@Pessimistress Pessimistress deleted the react-mapbox-api branch September 26, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pessimistress @ibgreen