Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TileLayer: add embed demo example #2814

Merged
merged 1 commit into from Mar 22, 2019
Merged

TileLayer: add embed demo example #2814

merged 1 commit into from Mar 22, 2019

Conversation

xintongxia
Copy link
Contributor

@xintongxia xintongxia commented Mar 20, 2019 •
edited

Background

v7.0 API audit

Change List

  • tile-layer.md
  • website demo

Screen Shot 2019-03-20 at 11 39 17 AM

@coveralls
Copy link

coveralls commented Mar 20, 2019 •
edited

Coverage Status

Coverage remained the same at 58.959% when pulling a9ac685 on xx/tile-layer into a219ac2 on master.

Pessimistress
Pessimistress approved these changes Mar 20, 2019
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot?

docs/layers/tile-layer.md Outdated Show resolved Hide resolved
@Pessimistress
Copy link
Collaborator

Set opacity to 1 to avoid the artifact at tile edges.

TileLayer: add embed demo example
a9ac685 
Allow missing data field in website demo example

fix typo

set opacity to 1
@xintongxia xintongxia merged commit 76291a0 into master Mar 22, 2019
@xintongxia xintongxia deleted the xx/tile-layer branch March 22, 2019 00:00
@xintongxia xintongxia mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xintongxia @coveralls @Pessimistress