Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up render passes #3733

Merged
merged 1 commit into from Oct 3, 2019
Merged

Clean up render passes #3733

merged 1 commit into from Oct 3, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Private method naming convention
  • Avoid unnecessary breaking/reconstructing parameter objects

@coveralls
Copy link

coveralls commented Oct 3, 2019 •
edited

Coverage Status

Coverage decreased (-2.7%) to 79.94% when pulling c0b1e21 on x/picking-flag into 39524c3 on master.

@Pessimistress Pessimistress merged commit 7e54a90 into master Oct 3, 2019
@Pessimistress Pessimistress deleted the x/picking-flag branch October 3, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhuang01 jianhuang01 jianhuang01 approved these changes

@tsherif tsherif Awaiting requested review from tsherif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @jianhuang01