Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3d picking projection with camera offset #3749

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix 3d picking projection with camera offset #3749

merged 2 commits into from
Oct 4, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • When the camera is not pointing to the ground, common space z must compensate for the offset.

@xintongxia
Copy link
Contributor

xintongxia commented Oct 4, 2019 •
edited

move the summary comment to code.

@coveralls
Copy link

coveralls commented Oct 4, 2019 •
edited

Coverage Status

Coverage increased (+2.7%) to 82.742% when pulling 14b1f9c on x/unproject-fix into fddf1ab on master.

@Pessimistress Pessimistress merged commit 2894929 into master Oct 4, 2019
@Pessimistress Pessimistress deleted the x/unproject-fix branch October 4, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @xintongxia @coveralls