-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove seer integration #3940
Remove seer integration #3940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to remove the mentioning of seer in documentations.
I get that cuts are sometimes necessary. That said it would be cool if there was a plan around the debug support in the frameworks - particularly if that plan made it clear that while some things are being phase out, the ambition is that the overall debug support will be getting better, or at least that maintainers are positive to accepting contributions in certain areas of debug support. I obviously think strong debug support is valuable for a suite of GPU focused libraries, so here are some simple things that could go into a roadmap:
More far out ideas:
|
@@ -310,12 +290,10 @@ export default class LayerManager { | |||
if (!oldLayer) { | |||
const err = this._initializeLayer(newLayer); | |||
error = error || err; | |||
initLayerInSeer(newLayer); // Initializes layer in seer chrome extension (if connected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could leave a hook here, something like LayerManager.callbacks.onInitialize
, it will allow users to add back similar functionalities using an external module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could leave a hook here, something like LayerManager.callbacks.onInitialize, it will allow users to add back similar functionalities using an external module.
I like that proposal! I am playing with the idea of setting up some open source "dot-gl" libraries from Unfolded's side that could contain some of the more experimental code that is being cut from the core libraries, plus some new stuff that we are developing that would be complementary to the existing frameworks.
That way the vis.gl core libraries could go ahead focus on being really small and hardened, but also provide the extensibility hooks so that we can continue to build out more experimental and advanced functionality (and if and when that matures we can always go back and make it official parts of the suite).
Done.
This could be cool, but I'd rather build a hook API like this around an actual usage so we know it provides something useful.
Agree that it would be nice to put together a plan around this. I'd love to see things function more in the plugin style like luma.gl/debug so you don't pay any cost for a tool if you're not using it. |
Well, the way I see it, seer was "actual usage". In my view, seer was actually very useful. And the deleted code shows exactly where hooks were needed... |
What I mean is if we want seer to be supported in this way, we should build and test seer support as a plugin, rather than just adding hooks and hoping everything works out. |
Yes that makes complete sense. With the caveat that it depends on how much work it would require signing up for, I'd be interested in helping out with that. |
No description provided.