Fix support for luma.gl buffers as external attributes #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1chandu
approved these changes
Jan 9, 2020
| @@ -216,7 +216,7 @@ export default class DataColumn { | |||
| this.value = opts.value; | |||
|
|
|||
| // Copy the type of the buffer into the accessor | |||
| accessor.type = buffer.accessor.type; | |||
| accessor.type = opts.type || buffer.accessor.type; | |||
There was a problem hiding this comment.
Once Buffer is created, type is fixed isn't it? why do we have to overwrite this? Is this covering non external buffer case?
There was a problem hiding this comment.
buffer.accessor.type is inferred from the data type array that is used to populate it by luma, but the chunk of memory can be interpreted as any data type in WebGL. This is needed if you use interleaved buffer with mixed data types.
Pessimistress
added a commit
that referenced
this pull request
Jan 9, 2020
chrisgervang
pushed a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4114
Change List
valueis missing from external buffertypeaccessor