-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BaseTileLayer to geo-layers #4232
Conversation
- Default: `null` | ||
|
||
|
||
##### `strategy` (Enum, optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong opinion here, but perhaps refinementStrategy
, tileRefinementStrategy
tileSelectionStrategy
etc might be a bit more clear than just strategy
?
- Default: `'best-available'` | ||
|
||
|
||
##### `tileToBoundingBox` (Function, optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I am wondering if there could be a
tileset
prop here, so that the user can pass in a Tileset2D instance? - And if so, several of the other advanced customization props could be specified (also, or exclusively) on the Tileset2D class
- A lot of the customization for e.g. non-geospatial user cases would happen by users subclassing and redefining Tileset2D
- If there was sufficient API alignment between tileset2D and tileset3D we might in the future just have a single TileLayer (essentially joining TileLayer and Tile3DLayer). This would of course require a serious generalization effort, so would come later, if at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea. It would require the Tileset2D class to be better defined and fully documented. I will open a follow-up PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I was just hacking around. I wanted to load a static set of tiles at a specific zoom level to work around the low performance of the TerrainLayer and implement a make-shift terrain geofence for a user. Any ideas?
@ilan-gold
See discussion in #4230 (comment)
Change List
BaseTileLayer
back togeo-layers