-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight features spread across tiles #4365
Merged
Pessimistress
merged 18 commits into
visgl:master
from
CartoDB:jb/mvttilelayer-highlight
Jun 5, 2020
Merged
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0e02049
Add highlightedObjectIndex method to TileLayer
jesusbotella a2ace35
Handle getHighlightedObject in MVTTileLayer
jesusbotella 8e7b97f
Merge branch 'master' into jb/mvttilelayer-highlight
jesusbotella 46426e0
Handle unhighlighting
jesusbotella 056baa5
Highlight MVT features only on autoHighlight
jesusbotella 8ec5756
Return highlightedObjectIndex in getHighlightedObjectIndex if present
jesusbotella bcbc750
Merge branch 'master' into jb/mvttilelayer-highlight
jesusbotella e4d922a
Add render tests
jesusbotella dd700a5
Add interaction test
jesusbotella b7b134a
Add uniqueIdProperty and highlightedObjectIndex properties to docs
jesusbotella d237c98
Address review comments
jesusbotella 99a94f4
Remove MVT Layer picking test
jesusbotella 839a186
Set highlightedFeatureId to null by default and add robust check
jesusbotella 1f56d74
Check feature id with in keyword
a1549aa
Change MVT layer docs to reflect property changes. Linter changes.
jesusbotella 60cc865
Consider as invalid any template data without replace method
jesusbotella 96a3351
Add MVT highlight node test
jesusbotella f3e09e8
Merge branch 'master' into jb/mvttilelayer-highlight
jesusbotella File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the feature id have to be a number? Is string accepted? If so, the default should be
null
for clarity?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per MVT docs, feature ID can be only a number. But it's true that if anyone uses
uniqueIdProperty
to reference an ID within feature properties, it could be a string.I have just changed it to support strings as well in the code. Let me know if you see something weird.