pydeck: Add Google Maps base maps to pydeck #4632
Conversation
|
|
| @@ -2,6 +2,9 @@ | |||
| <head> | |||
| <meta http-equiv="content-type" content="text/html; charset=UTF-8" /> | |||
| <title>pydeck</title> | |||
| {% if google_maps_key %} | |||
There was a problem hiding this comment.
I'd prefer we inject the google maps API programmatically (loadScript) rather than through a template injection. That would make this a much more portable part of the playground app.
We could just make a note of this in a tracker task and do that as a separate second PR.
There was a problem hiding this comment.
Noted here #4644
| container | ||
| }); | ||
| const {mapProvider} = props; | ||
| if (mapProvider === 'mapbox') { |
There was a problem hiding this comment.
Nit: prefer switch statement in this situation:
switch (mapProvider) {
case 'mapbox': ... break;
case 'google':
There was a problem hiding this comment.
I suppose we could even add arcgis here now if we wanted too...
| getTooltip, | ||
| container | ||
| }); | ||
| } else if (mapProvider === 'google_maps') { |
There was a problem hiding this comment.
Q: Provider = google_maps or just google?
I suppose google_maps is more consistent with googleMapsKey etc
ajduberstein
force-pushed
the
ajd/google-maps-in-pydeck
branch
from
637644b
to
0c86484
Compare
| ) { | ||
| switch (mapProvider) { | ||
| case 'mapbox': | ||
| console.debug('Using Mapbox base maps'); |
There was a problem hiding this comment.
Use log from @deck.gl/core
| }) { | ||
| googleMapsKey = props.googleMapsKey || googleMapsKey; | ||
| if (!googleMapsKey) { | ||
| deck.log.warn('No Google Maps API key set'); |
There was a problem hiding this comment.
This returns a function. You need to call it: log.warn(...)()
Make sure that you test this use case.
| version "3.0.0" | ||
| resolved "https://registry.yarnpkg.com/@jupyter-widgets/base/-/base-3.0.0.tgz#3996d566cddb742d275b007e0713de1e17f55a44" | ||
| integrity sha512-un1ZTHALCwE/SAYk2gEaonYM1JoaFyhosN8a3y2bhl4N26yCB3dP1PqGHLsAFur6ZB7fwuWwBEkIZx+nOwstAQ== | ||
| "@jupyter-widgets/base@^2": |
There was a problem hiding this comment.
Why is this changed without a corresponding change in package.json?
There was a problem hiding this comment.
I don't know, but yarn bootstrap also resolves this to 2.0.2 for me now.
There was a problem hiding this comment.
I think this is my fault. Somehow in #4573 I moved @jupyter-widgets/base to peerDependencies but either forgot to remove it from dependencies or rebased incorrectly or something.
So I think I had previously built and pushed the yarn.lock having removed @jupyter-widgets/base from dependencies, and it resolved to 3.0.0.
For #4323
Background
Support the addition of the Google Maps base map to pydeck
Works exclusively via
.to_htmlfor now, since I can add the Google Maps JS library as a script tag. Where is the most convenient place to fetch the library for the Jupyter transport module--as a custom library?Change List