pydeck: Correct JL2 dependency bug #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
This is to fix my oversight. In #4573, I moved @jupyter-widgets/base to peerDependencies but somehow forgot to remove it from dependencies or messed up a rebase.
It's interesting the diff is so large. Maybe @jupyter-widgets/base was being resolved twice?
Or it looks like now it isn't resolved at all, since it's a peerDependency, and should be provided by jupyter lab upon install.
I did test as a peerDependency in the original PR (#4573)
|
Well CI is failing. I suppose |
ibgreen
approved these changes
Jun 5, 2020
kylebarron
reviewed
Jun 5, 2020
| "@loaders.gl/3d-tiles": "^2.1.5", | ||
| "@loaders.gl/core": "^2.1.5", | ||
| "@loaders.gl/csv": "^2.1.5", | ||
| "@jupyter-widgets/base": "^1.1.10 || ^2 || ^3", |
There was a problem hiding this comment.
Might be helpful to alphabetize this and put it before @loaders.gl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #
Background
Change List