Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deck.gl transport: Support multiple connections #4654

Merged
merged 6 commits into from
Jun 5, 2020
Merged

deck.gl transport: Support multiple connections #4654

merged 6 commits into from
Jun 5, 2020

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jun 5, 2020

For #

Background

  • The transport must support multiple simultaneous connections

Change List

  • Sketch of changes to support this.

@ibgreen ibgreen marked this pull request as ready for review June 5, 2020 18:41
@ibgreen ibgreen changed the title deck.gl transport: Support multiple connections (WIP) deck.gl transport: Support multiple connections Jun 5, 2020
kylebarron
kylebarron reviewed Jun 5, 2020
View reviewed changes
modules/json/docs/transport.md
Longer term goals:

- `WebSocket` based transport
- Possibly add additional transports such as Colab notebook specific APIs.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser: postMessage based communication between tabs and iframes

I think that could work in Colab without needing another custom transport.

@coveralls
Copy link

coveralls commented Jun 5, 2020 •
edited

Coverage Status

Coverage decreased (-2.8%) to 80.417% when pulling 49887e5 on ib/transport-connections into d52a63f on master.

ajduberstein
ajduberstein approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@ajduberstein ajduberstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally, this works well!

@ajduberstein ajduberstein merged commit 77a7c2d into master Jun 5, 2020
@ajduberstein ajduberstein deleted the ib/transport-connections branch June 5, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron left review comments

@ajduberstein ajduberstein ajduberstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ibgreen @coveralls @ajduberstein @kylebarron