[test-utils] Add testLayerAsync #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kylebarron
approved these changes
Jun 12, 2020
Pessimistress
force-pushed
the
x/test-async
branch
from
8100bc5
to
0fd64d7
Compare
ibgreen
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
A bit more detail in the docs about the new testLayerAsync would probably be good. It could be clearer on what it waits for, the resource count system... Is it just waiting for all the async props for that layer to load? What it can be used for/intended for? etc.
It's waiting for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4365 (comment)
Note that the skipped MVTLayer test still does not pass with this PR. It will rely on #4658
Change List
testLayerAsyncto test-utilstestUpdateLayerandtestDrawLayer(not documented, not used)