Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pydeck: Additional formatting updates #4905

Merged
merged 2 commits into from
Sep 4, 2020
Merged

pydeck: Additional formatting updates #4905

merged 2 commits into from
Sep 4, 2020

Conversation

ajduberstein
Copy link
Collaborator

@ajduberstein ajduberstein commented Aug 30, 2020 •
edited

For #3640

This is from running make pre-commit within the pydeck folder. I think I'd prefer a shorter line length.

Background

Change List

@coveralls
Copy link

coveralls commented Aug 30, 2020 •
edited

Coverage Status

Coverage remained the same at 83.529% when pulling 0a57fcf on ajd/update-formatting-more into 703ca20 on master.

@kylebarron
Copy link
Collaborator

I think I'd prefer a shorter line length.

In pyproject.toml you have

line-length = 120

Are you suggesting decreasing it? (I personally always use line length 80)

@ajduberstein ajduberstein merged commit 90c7128 into master Sep 4, 2020
@ajduberstein ajduberstein deleted the ajd/update-formatting-more branch September 4, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajduberstein @coveralls @kylebarron