-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Tileset2D instance #5504
Conversation
Any exports must be documented. As a start, we may want to expose the layer prop ( |
If I understand what you are suggesting @kylebarron I think your second bullet point makes a lot sense in addition to "exporting the whole class." The |
Thanks for chiming in @ilan-gold! I think that one of the issues here is that in contrast to some of the other deck.gl layers, the
I think I'm searching for the best (and most maintainable) way to achieve this. I'd personally love to override just |
Does this have a chance of being accepted/implemented soon? Would love to have the ability to use the existing See my comment from this discussion |
At this stage I mostly want more feedback from users. What's the right abstraction to expose? How many of the internals would be useful for users to be able to override. |
Can we export this at least as _Tileset2D? |
Closing as superseded by #6848 |
Background
There's a lot of great tile selection logic in the
TileLayer
. However it's very much tied to the Web Mercator projection and OSM indexing system. There are use cases for displaying tiled data that isn't in the OSM tiling system. For example, if one wished to display tiled data in theGlobeView
, a "global geodetic" tiling system might be more appropriate, where there are two base tiles for each hemisphere, then a quadtree within each, and where each tile is in the WGS84 projection.I don't think it should necessarily be deck.gl's job to support other tiling systems, but I think it should be easier for an end user to extend the
TileLayer
's functionality.This is a very basic PR to expose the
Tileset2D
class, and is intended to start further discussion.Tileset2D
as a layer prop? I'm not aware of any other circumstances where a class is a prop. Should it be tied to theTileLayer
class instead, so that a user who wishes to change theTileset2D
would subclass theTileLayer
and swap out thetileset
attribute?getBoundingVolume
. However that's "locked away" inside a non-exportedOSMNode
class, so even with exposing theTileset2D
class, you'd still have to copy a substantial amount ofTileLayer
code into a custom app.Change List
Tileset2D
from@deck.gl/geo-layers
Tileset2D
as prop toTileLayer
.