fix(mapbox) leave additional views intact #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
commented
Oct 27, 2021
1 task
Pessimistress
approved these changes
Nov 5, 2021
| @@ -14,7 +14,7 @@ Use deck.gl layers as custom Mapbox layers, enabling seamless interleaving of Ma | |||
|
|
|||
| ### Limitations | |||
|
|
|||
| * deck.gl's multi-view system cannot be used. | |||
| * deck.gl's multi-view system only supports one MapView (e.g. minimaps are not supported). | |||
There was a problem hiding this comment.
Technically speaking you can have multiple MapViews, the limitation is that you will always have a MapView that fills the entire canvas (what Mapbox draws into).
There was a problem hiding this comment.
Ah, is that why minimap views can't use mapbox? I'd like to explain the limitation better in the overview in case its useful to someone hacking around it.
Pessimistress
force-pushed
the
chr/fix-mapbox-viewports
branch
from
e16ca37
to
6671fb9
Compare
Pessimistress
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The deck/mapbox interleaved rendering needs to reproject the viewport to match mapbox when an external deck object is provided. Currently the extension assumes the first View is a
MapViewand deletes any other viewports, however deletion is unnecessary and not expected if provided multiple views (e.g. a minimap or info viz overlay).Result After Fix
TextLayer on OrthographicView renders on top of interleaved MapView.
Change List
Related to interleaved mapbox rendering:
viewIdprovided - same behavior as todayviewIdprovided and found - replace specified viewportviewIdprovided and not found - do nothing