ComponentState should dereference component on finalize #7612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Hmm, I see, opening up for null-valued components does surface bunch of new corner cases and additional if-gauntlets adding to some of the most complex code.
The least painful antidote is presumably a best effort TSdoc pass and firming up API structure and typings where ever we can. .
| @@ -47,6 +47,9 @@ function initializeLayerManager({layer, viewport = testViewport, onError = defau | |||
|
|
|||
| export function testInitializeLayer(opts) { | |||
| const layerManager = initializeLayerManager(opts); | |||
| if (opts.finalize === false) { | |||
There was a problem hiding this comment.
Good time to move this test file to .ts and type out the options?
There was a problem hiding this comment.
The whole test-utils module is in JS. I will give it a pass in another PR.
Pessimistress
force-pushed
the
x/layer-finalize
branch
from
f624c7a
to
e528a67
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7605 (comment)
layer.getCurrentLayer()should returnnullif the layer has been removed.Change List
ComponentStateclears component reference when finalizedtestInitializeLayeradds option to defer finalization