Update example dependencies #7641
Merged
+439
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to see they you are switch to MapLibre GL JS in the examples. Cool to have you in the community! |
chrisgervang
approved these changes
Feb 15, 2023
| "react": "^16.3.0", | ||
| "react-dom": "^16.3.0", | ||
| "react-map-gl": "^5.0.0" | ||
| "mapbox-gl": "^2.0.0", |
There was a problem hiding this comment.
Should we also have a maplibre example? The packages are diverging overtime and it's a lot of effort to switch this example back and forth between them at the moment in testing.
There was a problem hiding this comment.
Yes I agree. I will open another PR to consolidate test apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7635
For all examples and test apps where it applies:
Change List
tscfrombuildscript. The examples do not currently contain their own tsconfig.json andtscjust fails.react-map-glto v7 and usemaplibre-glas map provider in all except the following examples:get-started/react/mapbox- depends onNavigationControlwhich is no longer supported in v7layer-browser- depends onNavigationControlwhich is no longer supported in v7safegraph(the mapbox integration example on the website) - for testing against the latest version of mapbox-glreactandreact-domto v18