-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor changing view controller type. #7814
Conversation
When replacing existing Views with changed Controller types, if the new Views happen to have the same ids, then the new Controller types are not honored, and instead the old, possibly incompatible Controllers are used instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't check if the view has changed, as the original TODO mentions. Could you also add that? Please also add some tests that demonstrate that this works
I think it's the view / controller combination that is the intention of the TODO comment. The change of the View is handled elsewhere. I added a test that demonstrates the issue. It fails without the changes in this PR. |
@felixpalmer would you mind taking another look? |
Background
When replacing existing Views with changed Controller types, if the new Views happen to have the same ids, then the new Controller types are not honored, and instead the old, possibly incompatible Controllers are used instead.
Change List