Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zoom and Compass widgets #8072

Merged
merged 49 commits into from
Mar 19, 2024
Merged

Add Zoom and Compass widgets #8072

merged 49 commits into from
Mar 19, 2024

Conversation

ilyabo
Copy link
Member

@ilyabo ilyabo commented Aug 22, 2023

For #7946

Change List

  • Add zoom widgets which renders Zoom in and Zoom out buttons
  • Add compass widget which resets bearing and pitch when clicked

Screen Shot 2024-03-18 at 9 20 37 PM

modules/widgets/src/zoom-widget.tsx Outdated Show resolved Hide resolved
modules/widgets/src/zoom-widget.tsx Outdated Show resolved Hide resolved
examples/get-started/pure-js/widgets/app.js Outdated Show resolved Hide resolved
examples/get-started/pure-js/widgets/app.js Outdated Show resolved Hide resolved
modules/widgets/src/zoom-widget.tsx Outdated Show resolved Hide resolved
modules/widgets/src/zoom-widget.tsx Outdated Show resolved Hide resolved
onAdd({deck}: {deck: Deck}): HTMLDivElement {
const {style, className} = this.props;
const element = document.createElement('div');
element.classList.add('deckgl-widget', 'deckgl-widget-compass');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with @ibgreen and @Pessimistress, we've decided to drop the gl. Couple reasons, it's shorter, we're long-term distancing from gl (onto WebGPU), and tooltip widget has always used .deck-tooltip.

@chrisgervang
Copy link
Collaborator

I've merged #8024 so this can target master now.

@ilyabo ilyabo changed the base branch from chr/fullscreen-widget to master September 26, 2023 07:10
@ilyabo
Copy link
Member Author

ilyabo commented Sep 26, 2023

Thanks @chrisgervang! Will try to update it soon

.eslintrc.cjs Outdated Show resolved Hide resolved
@ilyabo
Copy link
Member Author

ilyabo commented Mar 16, 2024

Thanks @chrisgervang for updating and resolving the conflicts!

Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang
Copy link
Collaborator

I've updated styles and icons to match our Figma design, and added a horizontal option for the zoom widget (or any button group). There is some polish to do, but this is pretty close.

compass-zoom.mov

@chrisgervang chrisgervang marked this pull request as ready for review March 19, 2024 00:20
@coveralls
Copy link

coveralls commented Mar 19, 2024

Coverage Status

coverage: 87.384% (+0.002%) from 87.382%
when pulling 6f2d415 on ilya/zoom-widget
into 77c2bf1 on master.

Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
@ilyabo
Copy link
Member Author

ilyabo commented Mar 19, 2024

I've updated styles and icons to match our Figma design, and added a horizontal option for the zoom widget (or any button group). There is some polish to do, but this is pretty close.

Looks really cool, thank you!

@chrisgervang chrisgervang merged commit 2571bc2 into master Mar 19, 2024
4 checks passed
@Pessimistress Pessimistress deleted the ilya/zoom-widget branch March 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants