-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zoom and Compass widgets #8072
Conversation
Co-authored-by: Ib Green <ib@foursquare.com>
Co-authored-by: Ib Green <ib@foursquare.com>
onAdd({deck}: {deck: Deck}): HTMLDivElement { | ||
const {style, className} = this.props; | ||
const element = document.createElement('div'); | ||
element.classList.add('deckgl-widget', 'deckgl-widget-compass'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion with @ibgreen and @Pessimistress, we've decided to drop the gl
. Couple reasons, it's shorter, we're long-term distancing from gl
(onto WebGPU), and tooltip widget has always used .deck-tooltip
.
I've merged #8024 so this can target master now. |
Thanks @chrisgervang! Will try to update it soon |
Signed-off-by: Chris Gervang <chris@gervang.com>
Thanks @chrisgervang for updating and resolving the conflicts! |
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
I've updated styles and icons to match our Figma design, and added a horizontal option for the zoom widget (or any button group). There is some polish to do, but this is pretty close. compass-zoom.mov |
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
Looks really cool, thank you! |
For #7946
Change List