Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pickObjects when using binary data #8253

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Fix pickObjects when using binary data #8253

merged 1 commit into from
Nov 11, 2023

Conversation

Pessimistress
Copy link
Collaborator

For #8197

pickObjects currently uses pickInfo.object to dedup results. When using binary data, pickInfo.object is always null. This PR falls back to use pickInfo.index in this case.

This is the same as #8216 without the breaking change. Targeting v8.x.

Change List

  • Return correct results when calling pickObjects with binary data
  • Unit test

@Pessimistress Pessimistress merged commit e2b1fd8 into 8.9-release Nov 11, 2023
3 checks passed
@Pessimistress Pessimistress deleted the x/pick-binary-fix-v8 branch November 11, 2023 01:38
Pessimistress added a commit that referenced this pull request Nov 11, 2023
@Pessimistress
Fix pickObjects when using binary data (#8253)
6f34061
@DanyRay420 DanyRay420 mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang chrisgervang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pessimistress @chrisgervang