Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carto/v8: fix CartoLayer tests #8436

Merged
merged 1 commit into from
Jan 19, 2024
Merged

carto/v8: fix CartoLayer tests #8436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/modules/carto/api/maps-api-client.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,6 @@ const TABLE_PARAMS = {
params: {...TABLE_PARAMS, type: MAP_TYPES.TILESET, geoColumn: 'geo'},
regex: /geoColumn parameter is not supported by type tileset/
},
{
title: 'query + columns',
params: {...TABLE_PARAMS, type: MAP_TYPES.QUERY, columns: ['geo']},
regex: /columns parameter is not supported by type query/
},
{
title: 'no geoColumn + aggregationExp',
params: {...TABLE_PARAMS, aggregationExp: 'sum(x) as y'},
Expand Down
8 changes: 5 additions & 3 deletions test/modules/carto/carto-layer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ mockedV3Test('CartoLayer#v3', async t => {
props: {
...props,
data: 'select * from table',
type: MAP_TYPES.QUERY
type: MAP_TYPES.QUERY,
columns: ['a', 'b']
},
onAfterUpdate
},
Expand All @@ -117,7 +118,8 @@ mockedV3Test('CartoLayer#v3', async t => {
props: {
...props,
data: 'table',
type: MAP_TYPES.TABLE
type: MAP_TYPES.TABLE,
columns: ['a', 'b']
},
onAfterUpdate
},
Expand Down Expand Up @@ -252,7 +254,7 @@ mockedV1Test('CartoLayer#should throw with invalid params for v1 and v2', t => {
},
regex: /geoColumn prop is only supported for type/i
})),
...[MAP_TYPES.TILESET, MAP_TYPES.QUERY].map(type => ({
...[MAP_TYPES.TILESET].map(type => ({
title: `should throw when columns prop is used with type ${type}`,
props: {
...layer.props,
Expand Down