Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] MapboxLayer #8442

Merged
merged 5 commits into from Jan 23, 2024
Merged

[v9] MapboxLayer #8442

merged 5 commits into from Jan 23, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Jan 22, 2024

For #8237.

Background

Change List

  • Update to Mapbox v2 to use WebGL2
  • Update to new h3 library
  • Update canvas/gl handling in luma

Current status: working, although depth is incorrect in interleaved mode

Screen.Recording.2024-01-22.at.16.31.08.mov

@felixpalmer felixpalmer changed the title [v9] WIP MapboxLayer [v9] MapboxLayer Jan 23, 2024
@felixpalmer felixpalmer mentioned this pull request Jan 23, 2024
26 tasks
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for myself - when updating the versions of dependencies in multiple package.json files throughout the workspace, is there a command or set of commands you're running? Or does this require going into each package and running the relevant yarn <foo> commands there?

I have ways I usually do this for a whole monorepo, but mine don't seem to work with alpha/beta releases, so I'm just curious here. :)

examples/website/safegraph/app.js Show resolved Hide resolved
examples/website/safegraph/package.json Show resolved Hide resolved
@felixpalmer
Copy link
Collaborator Author

is there a command

@donmccurdy I have this hacked together script for this, I can share it with you

@felixpalmer felixpalmer merged commit 898fbd4 into master Jan 23, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/fix-mapbox-example branch January 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants