Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump widget example to v9 #8492

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Bump widget example to v9 #8492

merged 3 commits into from
Feb 20, 2024

Conversation

chrisgervang
Copy link
Collaborator

For #7946

Background

Upgrading basic widget example to deck v9. Issue Observed: Beta 2 doesn't publish the stylesheet.css and didn't bundle preact correctly, so yarn start doesn't work. yarn start-local works though, which leads me to believe the preact bundle was fixed with #8460.

The stylesheet still isn't in the dist after running yarn build.. needs investigation.

luma.registerDevices([WebGLDevice]) doesn't seem necessary anymore. Is that right, @felixpalmer @ibgreen?

Change List

  • Bump widget example to v9
  • Remove luma.registerDevices([WebGLDevice]);

Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang merged commit b0c6e10 into master Feb 20, 2024
2 checks passed
@chrisgervang chrisgervang deleted the chr/fix-widget-example-v9 branch February 20, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants