Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template for linked-issues #8534

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

JayFoxRox
Copy link
Contributor

Background

The PR template tells users to use "For #" but that won't work with GitHub linked issues:

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Change List

  • Change PR template from "For #" to "Closes #"
  • Restructure PR template for readability

@Pessimistress
Copy link
Collaborator

What about the issues that require multiple PRs to fix?

@JayFoxRox
Copy link
Contributor Author

What about the issues that require multiple PRs to fix?

That's why I added: <!-- If it only partially resolves it, change this to "For #" -->

@coveralls
Copy link

Coverage Status

coverage: 89.987%. remained the same
when pulling e0a0015 on JayFoxRox:template-closes
into dd9853c on visgl:master.

@Pessimistress Pessimistress merged commit 9e4fa08 into visgl:master Apr 7, 2024
4 checks passed
@JayFoxRox JayFoxRox deleted the template-closes branch April 7, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants