Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) warn and error when WebGL1 detected #8548

Merged
merged 11 commits into from
Mar 8, 2024

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Feb 27, 2024

For #8523

Error and warns when attempting to interleave with a WebGL1 context.

Screen Shot 2024-03-06 at 5 16 23 PM

The basemap remains functional, deck just doesn't render.

Change List

  • error when WebGL1 detected
  • warn when incompatible basemap lib detected

Signed-off-by: Chris Gervang <chris@gervang.com>
@Pessimistress
Copy link
Collaborator

Pessimistress commented Feb 28, 2024

I think a generic warning/error should be issued by Deck class when props.gl is supplied. We have legacy use cases outside of MapboxOverlay that will encounter the same issue.

@chrisgervang chrisgervang changed the title fix(mapbox) warn and fail when WebGL1 detected fix(core) warn and error when WebGL1 detected Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 7, 2024

Coverage Status

coverage: 81.577% (+0.007%) from 81.57%
when pulling 5008a5e on chr/mapbox-overlay-interleaved-fix-v9
into 12b2532 on master.

@chrisgervang
Copy link
Collaborator Author

As discussed with @Pessimistress, I've updated this to log an error whenever WebGL1 is detected and a warning in the basemap integrations with a link to where our docs will cover mapbox/maplibre compatibility.

Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang added this to the v9.0 milestone Mar 7, 2024
@chrisgervang chrisgervang self-assigned this Mar 7, 2024
@chrisgervang chrisgervang merged commit f362eb9 into master Mar 8, 2024
3 checks passed
@chrisgervang chrisgervang deleted the chr/mapbox-overlay-interleaved-fix-v9 branch March 8, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants