Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples) Add interleaved mapbox-overlay to gallery #8556

Merged
merged 15 commits into from Mar 6, 2024

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Feb 27, 2024

For #8549

Change List

  • Add mapbox v3 interleaved example in mapbox-overlay
  • Links for maplibre-overlay interleaved example
  • Use maplibre v3 in MapboxLayer gallery example
  • Fix 3d buildings layer in maplibre examples

Signed-off-by: Chris Gervang <chris@gervang.com>
@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 70.671%. remained the same
when pulling fab6f69 on chr/use-maplibre-in-gallery
into 2e0fd4a on master.

@chrisgervang
Copy link
Collaborator Author

chrisgervang commented Mar 1, 2024

Hey @felixpalmer do you know if the carto tiles have 3D buildings? They look flat in this example compared to mapbox so it either isn't there, or the height property is named something other than height/min_height in the style

Screen Shot 2024-02-29 at 4 00 28 PM

Edit: Found the property with maputnik, its renamed to

'fill-extrusion-base': ['get', 'render_min_height'],
'fill-extrusion-height': ['get', 'render_height']

Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang changed the title chore(examples) Use maplibre in MapboxLayer gallery chore(examples) Add interleaved mapbox-overlay to gallery Mar 6, 2024
Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang mentioned this pull request Mar 6, 2024
25 tasks
@chrisgervang chrisgervang merged commit ef324f8 into master Mar 6, 2024
3 checks passed
@chrisgervang chrisgervang deleted the chr/use-maplibre-in-gallery branch March 6, 2024 18:09
@chrisgervang chrisgervang added this to the v9.0 milestone Mar 6, 2024
@chrisgervang chrisgervang self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants