Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating empty buffer for attributes #8576

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Avoid creating empty buffer for attributes #8576

merged 2 commits into from
Mar 5, 2024

Conversation

Pessimistress
Copy link
Collaborator

Prior to this PR, Attribute creates a buffer of size 0 and immediately deletes it during allocation.

It also fixes a memory leak when some layers overwrite the default instancePickingColors attribute. Test cases will be enabled in a follow-up PR.

Change List

  • Leave Attribute.buffer as null until allocated

@coveralls
Copy link

coveralls commented Mar 3, 2024 •
edited
Loading

Coverage Status

coverage: 70.671% (+0.001%) from 70.67%
when pulling eb3d806 on x/attribute-buffer
into 3737293 on master.

@Pessimistress Pessimistress merged commit bde0ef6 into master Mar 5, 2024
3 checks passed
@Pessimistress Pessimistress deleted the x/attribute-buffer branch March 6, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @ibgreen