Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IconManager upsizing auto-packed icon atlas #8673

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix IconManager upsizing auto-packed icon atlas #8673

merged 2 commits into from
Mar 18, 2024

Conversation

Pessimistress
Copy link
Collaborator

Requires visgl/luma.gl#2042

Change List

  • Replace legacy copyToTexture with v9 command
  • Restore render test

@felixpalmer
Copy link
Collaborator

@Pessimistress luma#2042 is now merged

@coveralls
Copy link

Coverage Status

coverage: 86.527% (+0.05%) from 86.476%
when pulling 0be12c4 on x/icon-manager-fix
into 963bbcf on master.

@Pessimistress Pessimistress marked this pull request as ready for review March 18, 2024 15:41
@Pessimistress Pessimistress merged commit 7be0fb3 into master Mar 18, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/icon-manager-fix branch March 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@donmccurdy donmccurdy Awaiting requested review from donmccurdy

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @felixpalmer @coveralls