New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not clear when rendering to target in PostProcessEffect #8705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If deck is going to support per-view or per-layer effects, I don't think this option should be set by the user. Clearing of the target should be disabled in PostProcessEffect always, and handled in DeckRenderer instead.
clearTarget
option in PostProcessEffect
@Pessimistress I've removed the user visible option. From my testing it doesn't seem that we need the explicit |
The canvas is auto cleared because preserveDrawingBuffer defaults to false. You should not rely on it, though. |
@Pessimistress updated to explicitly clear & tested with a canvas with |
For #8703
Background
Currently the
PostProcessEffect
clears the target it is drawing to. In order to implement per-layer postprocessing we need to disable this clearingChange List
clear
option toScreenPass
and set tofalse
when rendering totarget
inPostProcessEffect