Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Deck.finalize removes externally created canvas #8773

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(core): Deck.finalize removes externally created canvas #8773

merged 1 commit into from
Apr 10, 2024

Conversation

Pessimistress
Copy link
Collaborator

Closes #8768

Change List

  • Do not remove canvas if using user-supplied gl

@coveralls
Copy link

Coverage Status

coverage: 89.996%. remained the same
when pulling 7573a94 on x/finalize-fix
into bddd4cc on master.

@Pessimistress Pessimistress merged commit 5cc3987 into master Apr 10, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/finalize-fix branch April 10, 2024 14:24
Pessimistress added a commit that referenced this pull request Apr 12, 2024
@Pessimistress
fix(core): Deck.finalize removes externally created canvas (#8773)
bc26a20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]Using @deck.gl/arcgis@9.0.6: When using the map.remove(layer) method, the page goes blank.
3 participants
@Pessimistress @coveralls @donmccurdy