Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: Remove matchingColumn prop #8971

Merged
merged 3 commits into from
Jul 1, 2024
Merged

CARTO: Remove matchingColumn prop #8971

merged 3 commits into from
Jul 1, 2024

Conversation

felixpalmer
Copy link
Collaborator

Closes #8934

Background

Will not be supporting this prop

Change List

  • Remove matchingColumn prop
  • Test update

This was referenced Jun 21, 2024
Closed
Closed
@coveralls
Copy link

Coverage Status

coverage: 89.403% (-0.002%) from 89.405%
when pulling 0a440f9 on felix/carto-remove-matchingColumn
into a6e8bc3 on master.

@coveralls
Copy link

Coverage Status

coverage: 89.279% (-0.002%) from 89.281%
when pulling 60a4140 on felix/carto-remove-matchingColumn
into 898bda5 on master.

@felixpalmer felixpalmer merged commit 0cbded7 into master Jul 1, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/carto-remove-matchingColumn branch July 1, 2024 09:11
felixpalmer added a commit that referenced this pull request Jul 3, 2024
@felixpalmer
CARTO: Remove matchingColumn prop (#8971)
c5824f0
@srtena srtena mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] CARTO VectorTileLayer doesn't respect matchingColumn
3 participants
@felixpalmer @coveralls @donmccurdy