-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress to parseShapefileInBatches
.
#2073
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
type Batch = { | ||
data: number[] | number[][]; | ||
progress?: {bytesUsed: number; totalBytes: number; rows: number}; | ||
}; | ||
|
||
/** | ||
* Zip two iterators together | ||
* | ||
|
@@ -7,23 +12,23 @@ | |
export async function* zipBatchIterators( | ||
iterator1: AsyncIterator<any[]>, | ||
iterator2: AsyncIterator<any[]> | ||
): AsyncGenerator<number[][], void, unknown> { | ||
let batch1 = []; | ||
let batch2 = []; | ||
): AsyncGenerator<Batch, void, unknown> { | ||
let batch1 = {data: []}; | ||
let batch2 = {data: []}; | ||
let iterator1Done: boolean = false; | ||
let iterator2Done: boolean = false; | ||
|
||
// TODO - one could let all iterators flow at full speed using `Promise.race` | ||
// however we might end up with a big temporary buffer | ||
while (!iterator1Done && !iterator2Done) { | ||
if (batch1.length === 0 && !iterator1Done) { | ||
if (batch1.data.length === 0 && !iterator1Done) { | ||
const {value, done} = await iterator1.next(); | ||
if (done) { | ||
iterator1Done = true; | ||
} else { | ||
batch1 = value; | ||
} | ||
} else if (batch2.length === 0 && !iterator2Done) { | ||
} else if (batch2.data.length === 0 && !iterator2Done) { | ||
const {value, done} = await iterator2.next(); | ||
if (done) { | ||
iterator2Done = true; | ||
|
@@ -46,17 +51,22 @@ export async function* zipBatchIterators( | |
* @param batch2 | ||
* @return array | null | ||
*/ | ||
function extractBatch(batch1: number[], batch2: number[]): number[][] | null { | ||
const batchLength: number = Math.min(batch1.length, batch2.length); | ||
if (batchLength === 0) { | ||
function extractBatch(batch1: Batch, batch2: Batch): Batch | null { | ||
const {data: data1, progress} = batch1; | ||
const {data: data2} = batch2; | ||
const dataLength: number = Math.min(data1.length, data2.length); | ||
if (dataLength === 0) { | ||
return null; | ||
} | ||
|
||
// Non interleaved arrays | ||
const batch: number[][] = [batch1.slice(0, batchLength), batch2.slice(0, batchLength)]; | ||
const result: any = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be |
||
progress, | ||
data: [data1.slice(0, dataLength), data2.slice(0, dataLength)] | ||
}; | ||
|
||
// Modify the 2 batches | ||
batch1.splice(0, batchLength); | ||
batch2.splice(0, batchLength); | ||
return batch; | ||
// Modify the 2 data arrays | ||
data1.splice(0, dataLength); | ||
data2.splice(0, dataLength); | ||
return result; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the union? Seems like you'd only need one type?