Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump dependencies #764

Closed
wants to merge 3 commits into from
Closed

bump dependencies #764

wants to merge 3 commits into from

Conversation

xintongxia
Copy link

No description provided.

@xintongxia xintongxia requested a review from ibgreen June 3, 2020 04:35
@xintongxia xintongxia changed the title bump loaders.gl version bump dependencies Jun 3, 2020
@ibgreen
Copy link
Collaborator

ibgreen commented Jun 3, 2020

@Pessimistress @georgios-uber

  • The GLTF example lighting is broken on loaders.gl master. I assume some change to PBR or lighting etc.
  • Does it ring a bell?
  • We bumped all deps but seems that did not fix it.

ibgreen
ibgreen approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xintongxia thanks!

@Pessimistress Looks like lerna / ocular didn't bump the module dependencies automatically when I published the alpha... Any insights?

@ibgreen
Copy link
Collaborator

ibgreen commented Jul 3, 2020

Looks outdated now

@ibgreen ibgreen closed this Jul 3, 2020
@ibgreen ibgreen deleted the xx/bump branch July 6, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xintongxia @ibgreen