Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working gatsby website build #1089

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Working gatsby website build #1089

merged 3 commits into from
Apr 30, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 30, 2019 •
edited
Loading

For #756

Background

Change List

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.359% when pulling 58e069b on ib/gatsby-build into 6edf35a on master.

tsherif
tsherif approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@tsherif tsherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just curious about the two examples that had to be removed.

Might also be worth documenting how to display an example in the website, since there seem to be a few moving parts now.

website-gatsby/ocular-config.js
path: 'examples/core/instancing/',
image: 'images/example-instancing.jpg'
},
// {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this working?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Apr 30, 2019

Why isn't this working?

  • Instancing is failing due to the channel stuff.
  • glTF is failing due to the draco loader bundle size overwhelming the build process.

Also a bunch of smaller issues styling etc remain. But this solves the big blocker that previously prevented progress.

@ibgreen ibgreen merged commit 821cfb5 into master Apr 30, 2019
@ibgreen
Copy link
Collaborator Author

ibgreen commented Apr 30, 2019

Might also be worth documenting how to display an example in the website, since there seem to be a few moving parts now.

Yes, we'll need to update the documentation for ocular when all the dust settles.

@Pessimistress Pessimistress deleted the ib/gatsby-build branch July 26, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsherif tsherif tsherif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ibgreen @coveralls @tsherif